1
0
Fork 0
Commit Graph

1257 Commits

Author SHA1 Message Date
Irina Truong 005fd2fcee Releasing version 3.0.0 2020-04-10 15:16:44 -07:00
Amjith Ramanujam 2a28399c3f
Add an example for how to use the colored prompt. (#1163) 2020-03-30 09:32:00 +08:00
Georgy Frolov 61c81b05f5 removed py2-related stuff 2020-03-14 10:53:43 +08:00
g.denis 0f3d4602ef
Fix: Unable to drop previously connected-to database (#1152)
* close connections + added to authors + changelog

* check conn exists
2020-03-12 13:45:59 -07:00
赖信涛 bc7a5d0100
Drop Python3.5. (#1154)
* Drop Python3.5.

* delete 3.5 from setup.py

* fix black format. Using python3.7 for development now.

* black target to py36
2020-03-11 13:58:13 -07:00
赖信涛 fd77549754
Deprecate Python2.7. (#1153)
* deprecate Python2.7.

So we can use latest version of prompt-toolit.
Relate: https://github.com/dbcli/pgcli/pull/1149

* black format, remove 2.7 support.

* using version py35 for black.

* Revert "black format, remove 2.7 support."

This reverts commit 4b6d0496cc.

* deprecated py27 using black.

* remove 2.7 from travis.

* update setup.py: delete python 2.7 support.
2020-03-09 20:14:51 -07:00
lazydba247 91263c37b9
Add Support for partitioned tables. (#1145)
* partitioned tables: add support

Starting from 9.6+ relkind has new members (more info here: https://www.postgresql.org/docs/12/catalog-pg-class.html)

* Update AUTHORS

* Update changelog.rst

* foreign tables: add support

Starting from 9.6+ relkind has new members (more info here: https://www.postgresql.org/docs/12/catalog-pg-class.html)
2020-02-13 14:24:37 -08:00
George Thomas 77a361966a Fix warning raised for using `is not` to compare string literal (#1139)
Using `is not` for comparing string literals raises warning that != should be
used.

Fixes #1138
2020-01-14 20:56:07 -08:00
Jonas Jelten bc66b85730 add main file to allow python3 -m pgcli execution 2019-12-19 00:18:14 +01:00
Amjith Ramanujam 901812a7bf
Merge pull request #1122 from TheJJ/prompt-colors
support ansi escape sequences for prompt colors
2019-12-08 19:19:43 -08:00
Tim Gates 8456dcb18f
Fix simple typo: thows -> throws
Closes #1128
2019-12-05 08:35:22 +11:00
Irina Truong be04f1fc5e Releasing version 2.2.0 2019-12-04 09:25:02 -08:00
Jonas Jelten 36605174a4 support ansi escape sequences for prompt colors 2019-11-25 22:51:15 +01:00
Martin Matějek 6b2e8df8bd
run black again 2019-10-29 17:47:18 +01:00
Martin Matějek 01520ac728
Fix logging-format-interpolation 2019-10-29 02:57:00 +01:00
Martin Matějek a192255d7e
black formating 2019-10-29 02:56:28 +01:00
Amjith Ramanujam f3dc23a94b
Merge pull request #1112 from dbcli/j-bennet/pqconninfo-1110
[WIP] Fix for PQconninfo not available.
2019-10-28 10:08:59 -07:00
Amjith Ramanujam 43e79d0027 Use libpq version instead of psycopg2 version. 2019-10-26 19:45:02 -07:00
Irina Truong 270e1ce7a2 Log message. 2019-10-26 13:21:23 -07:00
Owen Stephens 995e7a9deb Disable escape-enter keybinding in vi mode
Escape then enter intended as two separate key presses is a very common
sequence when using vi mode - returning to normal mode from insert mode
(escape) and then submitting the query (enter). The presence of the
escape-enter key binding overrides this behaviour by inserting
undesirable newlines (newline is be easily inserted when in insert mode
by pressing enter) or by introducing a noticable delay/lag before enter
can be pressed after escape, due to prompt toolkit not being able to
recognise escape immediately (since it may form part of an escape-enter
sequence).
2019-10-23 23:12:54 +01:00
Amjith Ramanujam f25e49555a Fix the condition for <enter> key. (#1114)
* Fix the condition for <enter> key.

* Improve the debug message and remove debug statement.
2019-10-23 22:11:44 +01:00
Irina Truong 4f0c4d5a38 Fix for PQconninfo not available. 2019-10-19 11:36:38 -07:00
Amjith Ramanujam a713b5d08b
Merge pull request #1107 from owst/function_arg_completions_with_alias
Take account of table aliases when completing function args (#1048)
2019-10-16 20:57:19 -07:00
Owen Stephens e9b18f9e84 fixup! fixup! Take account of table aliases when completing function args (#1048) 2019-10-16 23:33:43 +01:00
Owen Stephens 629a931aed fixup! fixup! Handle a multi-line query on Enter key-press (fixes #1031) 2019-10-16 22:26:25 +01:00
Owen Stephens 6763433a68 fixup! Handle a multi-line query on Enter key-press (fixes #1031) 2019-10-13 13:50:36 +01:00
Owen Stephens 7f44748149 Handle a multi-line query on Enter key-press (fixes #1031)
Use a (conditional) Enter key-binding to force-handle a multi-line
buffer, rather than doing so by (conditionally) disabling the multiline
mode of prompt_toolkit.

This has the benefit of being more efficient (the multiline Condition
filter is called very often, which (due to the repeated query parsing)
causes editing to become slow with a large buffer that ends in a
semicolon), clearer in intent (we want to force-handle the query, rather
than (temporarily) disable multiline mode which indirectly forces the
buffer to be handled) and avoids a bug in multi-line history search
(issue #1031)
2019-10-13 01:07:57 +01:00
Owen Stephens b401b16d9a Take account of table aliases when completing function args (#1048) 2019-10-12 16:19:15 +01:00
Christopher Harrington 7a77eda241
rm Google Group from main.py 2019-09-29 14:16:55 -05:00
Irina Truong 04a74fce2c Get server params, such as is_superuser and server_version, without extra queries. 2019-08-28 08:26:24 -07:00
Irina Truong b2ebe0e95c
Issue 1018 display first 1k rows (#1092)
* Added changes to remove the prompt on >1000 rows queries

* Reformatted with black

* Changed comment on row_limit parameter

* Added contribution to changelog and name to AUTHORS

* Refactored test to reflect new functionality

* Removed argument

* Removed debug echo statement

* Reformatted with black

* Added changes to remove the prompt on >1000 rows queries

* Reformatted with black

* Changed comment on row_limit parameter

* Added contribution to changelog and name to AUTHORS

* Refactored test to reflect new functionality

* Removed argument

* Removed debug echo statement

* Reformatted with black

* Added missing issue numbers in changelog

* Reformatted code using black
2019-08-23 13:44:36 -07:00
Pedro Ferrari 19c3e0eeb8 Add key bindings to consistently move up and down in history (#1084) 2019-07-29 13:00:33 -07:00
Sebastian Janko f85642da67 Issue 1019 stacktrace on empty query (#1078)
* Added changes to skip empty queries

Empty queries consist of one or more semicolons

* Reformatted with black

* Added contribution to changelog and name to AUTHORS

* Black.
2019-07-12 17:24:39 -07:00
Irina Truong 10cc4ce2b9 Partial fix for #1058. (#1068) 2019-06-09 17:05:28 +02:00
Amjith Ramanujam f27ac1c110
Merge pull request #1064 from dbcli/amjith/slash-G
Add \G as a temporary way to use expanded mode.
2019-06-03 17:12:38 -07:00
Pablo 6d6ab3dab7 Add keybinding for alt-enter to introduce a line break (#1065)
* Add keybinding for alt-enter to introduce a line break.

* Update changelog.

* Added myself to AUTHORS file

* Fixed quote issue by pre-commit
2019-06-02 19:15:16 -07:00
Amjith Ramanujam 9abb4f8560 Run black. 2019-06-02 18:02:02 -07:00
Amjith Ramanujam 3a45620731 Add \G as a temporary way to use expanded mode.
This is similar to mycli.
2019-06-02 17:57:36 -07:00
Irina Truong 77bd30dc95 Releasing version 2.1.1 2019-05-30 17:11:03 -07:00
Irina Truong 8cb7009bcd
black all the things. (#1049)
* added black to develop guide

* no need for pep8radius.

* changelog.

* Add pre-commit checkbox.

* Add pre-commit to dev reqs.

* Add pyproject.toml for black.

* Pre-commit config.

* Add black to travis and dev reqs.

* Install and run black in travis.

* Remove black from dev reqs.

* Lower black target version.

* Re-format with black.
2019-05-25 13:08:56 -07:00
Irina Truong d661f63eec pep8. 2019-05-21 20:28:05 -07:00
Amjith Ramanujam 5177c9922e Add a behave test with spaces in password. 2019-05-15 23:40:21 -07:00
Amjith Ramanujam a45c67acf0 Handle password with spaces. 2019-05-13 15:13:15 -07:00
Irina Truong 300febccdd Dsn parameters not always present. (#1054)
* Dsn parameters not always present.
2019-05-11 07:57:45 +02:00
Amjith Ramanujam fe1b202c55
Merge branch 'master' into pr1047 2019-05-06 11:11:47 -07:00
Amjith Ramanujam 1908142adb Upgrade to sqlparse 0.3.0. 2019-05-06 09:05:56 -07:00
Amjith Ramanujam a6d44df4a7 Merge branch 'master' into pr1035 2019-05-06 07:18:46 -07:00
Amjith Ramanujam e5501cb83c Check if dsn and password values are passed in. 2019-05-06 06:34:24 -07:00
zzl 6d1b653e24 lazy load keyring. (#1046)
fix issue: https://github.com/dbcli/pgcli/issues/1041
2019-05-01 08:53:55 -07:00
Irina Truong 3fd91012f2
More intelligent dsn format (#1045)
* Psycopg2 already has a method to format a dsn. We should use it. Fix for #1043.

* Changelog.

* pep8.
2019-04-28 15:06:01 -07:00
Irina Truong 9a53fe859a Possibly fix #1040. (#1042)
Fix #1040
2019-04-28 08:00:40 +02:00
raylu eef0e0d65c Allow application_name to be overridden (#1044)
* Allow application_name to be overridden

* Fixed broken link.

* Default password value is empty str?

* Make pep8 happier.
2019-04-27 21:25:19 -06:00
Nathan Vērzemnieks 4af4e33e31 Allow escape to switch to vi navigation mode (#1039) 2019-04-13 13:22:03 -07:00
Xavier Francisco e0eac14c96 Revert main changes; Filter unwanted params when dsn present 2019-04-09 21:46:20 +01:00
Xavier Francisco 49582ccb7c Fix usage of pgservice 2019-04-08 19:46:29 +01:00
Irina Truong 098a2cf976 Releasing version 2.1.0 2019-04-05 17:26:27 -07:00
Irina Truong 3f0e47d7b3 Ask for password in case of incorrect password. 2019-03-22 16:49:54 +00:00
Irina Truong d25d27846a Fix for https://github.com/dbcli/pgcli/issues/1014. 2019-03-18 03:09:26 +00:00
Amjith Ramanujam 3652134bc5
Merge branch 'master' into system-error 2019-03-16 21:18:21 -07:00
Amjith Ramanujam 83e17e825f Remove the expand_tab option from pgclirc. 2019-03-16 14:09:39 -07:00
Amjith Ramanujam cbd944ffab
Merge branch 'master' into tab-on-line-start 2019-03-16 14:06:24 -07:00
Amjith Ramanujam 9df9c222d0 Remove the unnecessary try/except. 2019-03-16 13:36:32 -07:00
Amjith Ramanujam f4ebcd2383 Access only the required element from the tuple. 2019-03-16 13:34:36 -07:00
Amjith Ramanujam 951cfb28a7 Catch and ignore the system interrupt. 2019-03-15 20:28:40 -07:00
Irina Truong 33dbb602de Fix crash when using --single-connection. 2019-03-04 16:09:12 -08:00
Scott Brenstuhl 1c66dece59 Add reconnect automatically enhancement (#1009)
* Adding reconnect automatically enhancement

* files for pr checklist

* changelog fixes

* setting auto-reconnect to be the default

* fix issue of getting logged queries instead of most recent

* travisci pep8 check issue
2019-02-23 16:37:26 -08:00
ಠ_ಠ bd0aaefdd2 keybinding for dismissing autocompletelist (#1007)
* +added esc key to dismiss the autocomple list

* +added esc key to dismiss the autocomple list
2019-02-12 16:18:32 -08:00
Marcin Cieślak ef8aac61c4 Determine hstore OID from the system view (#992)
Avoid error message on the server side if hstore
extension is not installed in the current database.

Issue: https://github.com/dbcli/pgcli/issues/991
2019-01-21 16:00:25 -08:00
Mikhail Elovskikh f614cef7ed Support multihost connection string (#978)
* Switch to psycopg2 parse_dsn instead of urlparse

* Added wronglink to contributors and updated changelog

* Fix test codestyle

* Support for PGPORT customization in tests

* Support for PGPORT customization in tests

* Refactored PGExecute init and moved short_host generation to object property

* Fix test util codestyle

* Fix local tests run

* Store PGExecute initial params in  _conn_params and added PGExecute.copy method

* Fix codestyle

* Added docstring to PGExecute.copy() method
2019-01-03 14:27:47 -08:00
Irina Truong a7650887bf Releasing version 2.0.2 2019-01-02 16:31:52 -08:00
Irina Truong 0cae7e2036
Remove some functions completions (#982)
Remove extension and private functions from completer.
2019-01-02 16:15:59 -08:00
Irina Truong f7303f6988 pep8. 2018-12-27 15:56:22 -08:00
Irina Truong dfdac52b4d Wrap pgcli completer into ThreadedCompleter. 2018-12-27 15:55:56 -08:00
Irina Truong b634656c21 pep8. 2018-12-03 09:01:32 -08:00
Irina Truong 679d7939bb Time execution separately. 2018-12-01 18:23:50 -08:00
igncampa 7b03f8e204 allow passing -u flag (lowercase) to specify username (#975)
* added -u flag
2018-11-30 15:21:12 -08:00
Irina Truong ca2d96825b Releasing version 2.0.1 2018-11-18 20:26:21 -08:00
Amjith Ramanujam 25a66ecfb3 Fix the StopIteration issue in Python 3.7 (#971)
* Fix the StopIteration issue in Python 3.7
2018-11-18 20:11:15 -08:00
Amjith Ramanujam 923f2d6441 Enable suspend using C-Z. (#970)
* Enable suspend using C-Z.

* Update changelog.
2018-11-17 19:41:34 -08:00
Amjith Ramanujam 945461bfa2
Merge branch 'master' into tab-on-line-start 2018-11-17 19:34:36 -08:00
Amjith Ramanujam ec18ff0141
Merge branch 'master' into bugfix/named-queries-from-config 2018-11-17 11:25:20 -08:00
Amjith Ramanujam 462443a2d1
Merge pull request #961 from DanEEStar/feature/dbname-username-options
Refactor dbname and username options/arguments to match `psql`-behaviour
2018-11-17 11:15:13 -08:00
Dick Marinus 94475e6283 Require prompt_toolkit>=2.0.6. 2018-11-11 13:42:33 -08:00
Daniel Egger b92743368b Bugfix for #938: load named queries from provided config file 2018-10-31 18:46:04 +01:00
Daniel Egger f71a70fc93 Refactor dbname and username options/arguments to match `psql`-behaviour 2018-10-30 23:25:22 +01:00
DanEEStar abb801e4af Set default port in `get_prompt` when none is given, fixes #958 (#959) 2018-10-30 07:28:28 -07:00
Irina Truong fcf0eb022e
Fix for pgcli --list. (#952)
Fix for pgcli --list
2018-10-02 17:10:43 -07:00
Artur Balabanov f897ea466e Merge branch 'master' into tab-on-line-start 2018-10-01 10:25:13 +01:00
Irina Truong ec5131e1da Releasing version 2.0.0 2018-09-29 02:51:58 +00:00
Irina Truong 392491a74d
Cherry-picked prompt-toolkit 2.0 changes. (#930)
* Cherry-picked prompt-toolkit 2.0 changes.

* Increase help timeout.

* Missed one.

* Fixes editor command.

* Expect exact to fix named query error.

* Unicode is non-optional with ptk 2.0.

* Unicode literals all the things (almost).

* PEP8.

* Change how we swap completers.

* By default, bottom toolbar styles are reversed. We don't want that.

* Adapt styles to 2.0.

* The future is now. Switch to ptk 2.0 style names.

* PEP8.

* Flag for enable_open_in_editor.

* add class:prompt to prompt

* Removed workaround for #668. Some renaming.

* use pgcli.completer instead of app.current_buffer.completer

* enable_system_prompt=True like old prompt toolkit

* keep search_ignore_case enabled (was ignore_case)

* fix closing parenthese

* keep marking class:continuation token for continuation

* capture KeyboardInterrupt manually

AbortAction has been removed in Prompt_toolkit 2.0

* replace C-J with enter, add more comments

* reversed ([...]) to [(...)] (oops)

* pep8 fixes

* Does Vi mode have to be applied to session every time?

* (workaround) also enable vi_mode after edit command

* Fixed test errors after rebasing on master.
2018-09-28 14:18:40 -07:00
Irina Truong d3bdb891d3 Releasing version 1.11.0 2018-09-24 16:25:12 -07:00
Max Rothman 172c9cd271 Respect \pset pager on expected behavior
"\pset pager" has three possible values: "always", "on", and "off".
pgcli previously treated all non-"off" values as "always". This change
implements the expected behavior, which is to use the pager when the
output is larger than the terminal height (See \pset pager in
https://www.postgresql.org/docs/9.2/static/app-psql.html). Pgcli adds to
this by also using the pager when the output is wider than the terminal
width.

Fixes #813
2018-09-23 17:02:08 -04:00
Artur Balabanov 7602998c81 On the first line only autocomplete is always triggered, regardless of whether it's empty or not 2018-07-29 09:38:23 +01:00
Artur Balabanov 77170407ad Access the current line directly from the Document instance instead of calculating it manually 2018-07-29 09:35:15 +01:00
Irina Truong 5834259535 Releasing version 1.10.3 2018-07-27 12:06:53 -07:00
Artur Balabanov 3cef794dd4 PEP8 warnings fixed 2018-07-27 18:08:03 +01:00
Artur Balabanov 676b5e6ff6 Add a config option -- expand_tab. If set, \t character will be replaced by 4 spaces when a <Tab> key is pressed on an empty line 2018-07-27 17:07:18 +01:00
Artur Balabanov 2870103d5d Docstring updated for the Tab key binding method 2018-07-27 16:47:15 +01:00
Artur Balabanov 205949a79b Tab press on an empty line is interrupted as a \t character insert 2018-07-27 16:44:38 +01:00
Irina Truong 9063f02256 Fixes keyring = False not honored. 2018-07-26 05:09:23 +00:00
Lele Gaifax 05ec05c4cb Adapt the query used to get functions metadata to PG11
This fixes #919.
2018-07-25 08:13:17 +02:00
Irina Truong 22d184dc6b Change server version query. 2018-07-24 15:14:53 -07:00
Irina Truong e4f02b247e Releasing version 1.10.2 2018-07-23 17:09:57 -07:00
Dick Marinus 868b81aa98 make keyring optional 2018-07-22 07:34:56 +02:00
Irina Truong 7653ea9c1f Print server version as part of welcome message. 2018-07-20 15:47:40 -07:00
Irina Truong 2fa7b1458a Releasing version 1.10.1 2018-07-20 09:08:18 -07:00
Irina Truong 83b2981a0f Fixes #909. 2018-07-19 18:21:33 -07:00
Kenny Do 408c0329ec pass when no supported keyring backend available 2018-07-19 14:11:27 -07:00
Irina Truong 79e4dbcf11 Releasing version 1.10.0 2018-07-14 12:59:10 -07:00
Irina Truong 5491d288fc
Merge pull request #903 from arturbalabanov/render-tabs-with-spaces
Fixes #346: Tab characters are rendered with spaces instead of "^I" when entered in external editor
2018-07-13 13:24:44 -07:00
Amjith Ramanujam 6eedf1b6e3 Catch the ^D keybinding using EOFError exception. 2018-07-10 22:51:38 -07:00
Artur Balabanov 44d4275eae Prettify the code to keep Travis happy :) 2018-07-06 18:02:52 +01:00
Artur Balabanov 87451b3806 A new input processor has been added that renders tab characters as spaces instead of the ugly '^I' 2018-07-06 17:37:43 +01:00
Saif Hakim 80957c59c5 Fix lint, update AUTHORS, and changelog 2018-07-04 01:36:50 -07:00
Saif Hakim 5cdb151999 Avoid reconnect prompt after error if connection is still valid
Instead of whitelisting all errors that do not require reconnecting, we simply
only reconnect if we detect a disconnect has occurred.

psql notably behaves in a similar way: https://git.io/fbxuc#L1461

Fixes #807
2018-07-03 23:56:26 -07:00
Amjith Ramanujam 4c173fd01f Gurad against missing keyring backend. 2018-06-25 13:55:54 -07:00
Irina Truong 10f190a13a Rebase conflict. 2018-06-17 17:21:03 -07:00
Irina Truong a26b8b92a2 Pep8. 2018-06-17 14:34:20 -07:00
Irina Truong 4b06769002 Can't add tuple and list. 2018-06-17 14:21:30 -07:00
Irina Truong aa58fbf028 Non-existent function will raise a ProgrammingError. 2018-06-16 21:49:28 -07:00
Irina Truong 8ee20aa82e Fix for 'only named arguments may follow *expression' 2018-06-16 21:49:28 -07:00
catherinedevlin 74daa23a45 switched view query to imitating psql 2018-06-16 21:47:18 -07:00
catherinedevlin bb8cbac3de Added \ef 2018-06-16 21:46:31 -07:00
catherinedevlin 675e1dbff2 Moved code to pgexecute 2018-06-16 21:46:31 -07:00
Alexandr Korsak da12182609 Fix formatting for --user 2018-06-15 10:52:28 +03:00
Alexandr Korsak 4963e34c3a add compatible --user like psql command 2018-06-15 09:07:32 +03:00
Matthieu Guilbert f13637aa21 Fix unbound local error when destructive_warning is false 2018-06-10 16:36:51 +08:00
Matthieu Guilbert 1a2421892b fix: not enough values to unpack 2018-06-07 00:43:48 +08:00
Irina Truong b8a6dfd357 Ugh. 2018-06-01 14:00:57 -07:00
Irina Truong 9e54a9ef56 Fix for ipython sql connection. Fixes #891. 2018-06-01 08:18:24 -07:00
Dick Marinus 2ce2a87f37 make keyring optional 2018-05-26 11:26:06 +02:00
Amjith Ramanujam 9ae9df624f
Merge branch 'master' into feature/get-last-sql-query 2018-05-18 21:48:21 -07:00
Amjith Ramanujam 0643fd6534
Merge branch 'master' into master 2018-05-17 05:57:46 -07:00
Dan Clark 8fce953a8c ported the desctructive warning from mycli 2018-05-17 05:54:50 -04:00
Amjith Ramanujam 8e12ea5e0f
Merge pull request #873 from cfournie/remember_passwords
Remember prompted passwords using keyring
2018-05-16 17:49:31 -07:00
Rishi Ramraj f520b2ebb2 Add is_special to the \\o command 2018-05-15 11:57:19 -04:00
Rishi Ramraj b44357dc67 Fix typo 2018-05-15 10:54:07 -04:00
Rishi Ramraj 3425766dea Code review fixes 2018-05-15 10:45:36 -04:00
Amjith Ramanujam 5990e55413 Restrict the offer to reconnect. 2018-05-15 10:06:50 -04:00
Rishi Ramraj 07e54fb69f Fix is_special flag 2018-05-15 01:25:33 -04:00
Rishi Ramraj ca63a54ada Add special flag 2018-05-15 00:51:44 -04:00
Rishi Ramraj a49f5bdd0f Add is_special to run return 2018-05-15 00:35:07 -04:00
Rishi Ramraj 54942ce0d7 Remove unnecesssary parameter 2018-05-14 20:37:16 -04:00
Amjith Ramanujam f8757c6f59
Merge pull request #879 from dbcli/pr877
Fix lint complaints.
2018-05-14 17:33:06 -04:00
Amjith Ramanujam d971e49993
Merge pull request #877 from catherinedevlin/keep_callables
Keep callables
2018-05-14 17:32:11 -04:00
Amjith Ramanujam 740d4f1249 Fix lint complaints. 2018-05-14 17:30:52 -04:00
Jason Ribeiro 9014d96526 Add completion for table formats 2018-05-14 16:54:52 -04:00
catherinedevlin dc74a0acd0 Merge remote-tracking branch 'upstream/master' into keep_callables 2018-05-14 16:31:19 -04:00
catherinedevlin 0d00e38b6d prevent losing saved_callables on error 2018-05-14 16:04:31 -04:00
Amjith Ramanujam 7d0f866afb Fix lint complaints. 2018-05-14 14:58:17 -04:00