mirrors
/
pgcli
mirror of https://github.com/dbcli/pgcli
1
0
Fork 0
Code

fix bug where columns from a nonvisible table could contribute suggestions when a a query references an unqualifed, visible table of the same name

This commit is contained in:
Darik Gamble 2015-01-20 17:06:54 -05:00
parent ab7edd955c
commit eb66d8b3e0
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pgcli/pgcompleter.py
View File

@ -200,8 +200,10 @@ class PGCompleter(Completer):
# Only allow unqualified table reference on visible tables
vis_tables = self.tables[self.tables['is_visible']]
unqualed_tables = scoped_tbls.merge(vis_tables, how='inner', on=['table'])
unqualed = unqualed_tables.merge(columns, how='inner', on=['table'])
unqualed_tables = scoped_tbls.merge(vis_tables,
how='inner', on=['table'], suffixes=['_left', '_right'])
unqualed_tables['schema'] = unqualed_tables['schema_right']
unqualed = unqualed_tables.merge(columns, how='inner', on=['schema', 'table'])
return list(qualed['column']) + list(unqualed['column'])